-
-
Notifications
You must be signed in to change notification settings - Fork 442
Set terrain
arg to store true.
#374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hm, this is failing with the following:
(with a
|
I'll add a unit test that verifies this before merging. |
5bdea24
to
afdfc0a
Compare
|
afdfc0a
to
fc96663
Compare
c25cb5f
to
358ad53
Compare
This was erroneously set to `SetFalse`, which means it's impossible to enable the terrain from the cli. According to clap docs, the default action for a bool arg is SetTrue, and the default value is false. (https://docs.rs/clap/latest/clap/_derive/index.html#arg-types) So we don't need to provide any additional args here.
358ad53
to
6429280
Compare
@louis-e once CI passes, this is ready for signoff |
Merged
So I guess we're starting with unit tests now ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was erroneously set to store false, which means it's impossible to enable the terrain from the cli.