Added ores generation in quarries #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin051000
approved these changes
Feb 1, 2025
|
I just added another feature that can be enabled in the settings. It fills the underground space with stone, I think it can be useful for many users, but it also should be disabled by default because it increases generation time significantly. Only applies when terrain is enabled. Also now there's bedrock at level -64 for both modes. |
benjamin051000
approved these changes
Feb 4, 2025
src/data_processing.rs
Outdated
Comment on lines
175
to
177
| for y in MIN_Y + 1..max_y - 2 { | ||
| editor.set_block(STONE, x, y, z, None, None); | ||
| } |
There was a problem hiding this comment.
Use editor.fill_blocks() instead.
src/element_processing/landuse.rs
Outdated
Comment on lines
369
to
371
| for y in MIN_Y + 1..ground_level { | ||
| editor.set_block(STONE, x, y, z, None, None); | ||
| } |
There was a problem hiding this comment.
editor.fill_blocks()
benjamin051000
suggested changes
Feb 4, 2025
Trying to fix compilation error
|
I am not sure if I did it right, let's just hope I didn't break anything... |
|
@benjamin051000 thank you for your advice, this is really better and also ground generation feels faster now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous pull I only added landuse for quarries and landfills, so there would be stone in quarries, but I did not add ores as said in #330, now I added ores as well
Fixes #330