fix(utils.dictionary): use deep copy instead of assignment

loqusion · May 7, 2024 · 3be55a1 · 3be55a1
1 parent fa60954
commit 3be55a1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/hyprshade/utils/dictionary.py b/src/hyprshade/utils/dictionary.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from copy import deepcopy
 from typing import Literal, TypeAlias
 
 DeepMergeStrategy: TypeAlias = Literal["force", "keep"]
@@ -13,9 +14,9 @@ def __deep_merge_impl(
             if isinstance(dest[key], dict) and isinstance(source[key], dict):
                 __deep_merge_impl(dest[key], source[key], strategy=strategy)
             elif strategy == "force":
-                dest[key] = source[key]
+                dest[key] = deepcopy(source[key])
         else:
-            dest[key] = source[key]
+            dest[key] = deepcopy(source[key])
 
     return dest
 

diff --git a/tests/utils/test_dictionary.py b/tests/utils/test_dictionary.py
@@ -61,3 +61,9 @@ def test_referential_equality(self):
         d: dict = {}
         assert deep_merge(d, {"foo": "bar"}, strategy="force") is d
         assert deep_merge(d, {"baz": "qux"}, strategy="keep") is d
+
+    def test_referential_inequality(self):
+        d: dict = {}
+        a = [1, 2, 3]
+        deep_merge(d, {"foo": a})
+        assert d["foo"] is not a