Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DiffScene spec: calling getLoadedSpecs changes preloadedState #1172

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

patnir41
Copy link
Contributor

@patnir41 patnir41 commented Aug 31, 2022

Files of relevance: DiffScene.spec.tsx, testReduxUtils.tsx

This issue occurs specifically when I include the testReduxUtils.tsx file. If you delete this file and where it's exported, the following will not occur:

When running the test in DiffScene.spec.tsx, I plan to create a test store with default values initialized. This is determined from preloadedState which is explicitly defined with the default values I need. If you don't call getLoadedSpecs, preloadedState will be initialized as expected. Calling getLoadedSpecs somehow changes the preloadedState to have undefined values.

@github-actions
Copy link
Contributor

APIX Tests

0 files   -     1  0 suites   - 86   0s ⏱️ - 6m 34s
0 tests  - 408  0 ✔️  - 395  0 💤  - 13  0 ❌ ±0 
0 runs   - 428  0 ✔️  - 415  0 💤  - 13  0 ❌ ±0 

Results for commit 213b956. ± Comparison against base commit a4ac3bc.

This pull request removes 408 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
APIErrorDialog defaults an empty error message ‑ APIErrorDialog defaults an empty error message
APIErrorDialog is hidden if open is false ‑ APIErrorDialog is hidden if open is false
APIErrorDialog ok button click fires ‑ APIErrorDialog ok button click fires
APIErrorDialog shows detailed errors ‑ APIErrorDialog shows detailed errors
APIErrorDialog shows simple errors ‑ APIErrorDialog shows simple errors
APIErrorDialog skips empty documentation url ‑ APIErrorDialog skips empty documentation url
APIErrorDisplay defaults an empty error message ‑ APIErrorDisplay defaults an empty error message
APIErrorDisplay fetches error doc ‑ APIErrorDisplay fetches error doc
…

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit d4fd98d.

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 61aa320.

@patnir41 patnir41 requested a review from a team as a code owner March 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants