Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD 2025-01 Updates #2520

Merged
merged 12 commits into from
Jan 26, 2025
Merged

RTD 2025-01 Updates #2520

merged 12 commits into from
Jan 26, 2025

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Jan 25, 2025

No top level issue. I took the time to do some cleanup after I noticed a collection of things while writing the LT Gamer's guide. This PR:

  • Includes a new global-includes file that we can use at the top of each file. Makes it much easier to include a standard block.
  • Fixes some issues w/ how tables were formatted. Had a bug in our custom .css.
  • Ensures every table has a numref
  • Many updates to the style guide
  • Moved some tables to a list-table type. Fixes Terrain matching summary table is too wide #1731, and makes managing the large tables in the LT Gamer's guide much simpler going forward.
  • Stop pinning Sphinx to <7.2.

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 25, 2025

@lmoureaux
Copy link
Contributor

I don't think this is wanted?
image

@lmoureaux
Copy link
Contributor

I don't think this is wanted? image

Hmm, already there in master...

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 25, 2025

Yea its been that way for some time. I forget what it looked like "before".

@jwrober jwrober requested a review from blabber January 25, 2025 22:59
@lmoureaux
Copy link
Contributor

It's from the following rule in our theme_overrides.css:

.toctree-wrapper li, .current li {
    margin-bottom: 3px;
}

Should be 0px for the sidebar, not sure why it was changed.

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 25, 2025

I added that awhile ago to give some space between bullets. I'll push another commit.

Copy link
Collaborator

@blabber blabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwrober jwrober merged commit 80176af into longturn:master Jan 26, 2025
21 checks passed
@jwrober jwrober deleted the docs/2025-01-updates branch January 26, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terrain matching summary table is too wide
3 participants