docs: fix code error for API protection with node(express) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohanyu
force-pushed
the
docs/fix-code-error-for-node
branch
from
6af00c3 to
ce72854
Compare
|
@wangsijie please help review |
wangsijie
reviewed
Dec 18, 2023
yes. For the typescript warnings, I am not sure whether you guys are aware of this or have other better ideas, so this part is not in the PR. |
wangsijie
approved these changes
Dec 22, 2023
wangsijie
force-pushed
the
docs/fix-code-error-for-node
branch
from
ce72854 to
31b4a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just fix some simple code error for API protection docs with node(express).
Note
The code
will result in a typescript warning:
From what I can see in the core repo, the code has been improved and get rid of the TypeScript error.
Not sure whether you guys would fix this typescript warning in docs code snippet.