fix optimizer bug

loda-lang · Sep 13, 2024 · 86ef769 · 86ef769
1 parent e50048f
commit 86ef769
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@ To install or update LODA, please follow the [installation instructions](https:/
 
 ## [Unreleased]
 
+### Bugfixes
+
+* Fix optimizer bug
+
 ## v24.9.7
 
 ### Bugfixes

diff --git a/src/eval/optimizer.cpp b/src/eval/optimizer.cpp
@@ -793,11 +793,6 @@ bool Optimizer::collapseMovLoops(Program &p) const {
     if (val < Number::ZERO) {
       p.ops.erase(p.ops.begin() + i, p.ops.begin() + i + 3);
       changed = true;
-    } else if (val == Number::ZERO) {
-      p.ops.erase(p.ops.begin() + i + 1, p.ops.begin() + i + 3);
-      p.ops[i] = Operation(Operation::Type::MOV, lpb.target,
-                           Operand(Operand::Type::CONSTANT, 0));
-      changed = true;
     } else {
       p.ops.erase(p.ops.begin() + i + 1, p.ops.begin() + i + 3);
       p.ops[i] = Operation(Operation::Type::MIN, lpb.target,

diff --git a/tests/optimizer/E047.asm b/tests/optimizer/E047.asm
@@ -5,4 +5,6 @@ lpb $0
 lpe
 add $0,7
 ; out
-mov $0,7
+add $0,3
+min $0,0
+add $0,7
diff --git a/tests/optimizer/E049.asm b/tests/optimizer/E049.asm
@@ -0,0 +1,10 @@
+; in
+sub $0,3
+lpb $0
+  mov $0,0
+lpe
+sub $0,7
+; out
+sub $0,3
+min $0,0
+sub $0,7