fix linter warnings

src/oeis/oeis_manager.cpp

@@ -140,7 +140,6 @@ void OeisManager::loadData() {
       throwParseError(line);
     }
     total_count++;
-    pos = 1;
     id = 0;
     for (pos = 1; pos < line.length() && line[pos] >= '0' && line[pos] <= '9';
          ++pos) {
@@ -203,7 +202,6 @@ void OeisManager::loadNames() {
     if (line[0] != 'A') {
       throwParseError(line);
     }
-    pos = 1;
     id = 0;
     for (pos = 1; pos < line.length() && line[pos] >= '0' && line[pos] <= '9';
          ++pos) {
@@ -273,8 +271,7 @@ bool OeisManager::shouldMatch(const OeisSequence &seq) const {
   }
 
   // check if program exists
-  const bool prog_exists = (seq.id >= 0) &&
-                           (seq.id < stats->all_program_ids.size()) &&
+  const bool prog_exists = (seq.id < stats->all_program_ids.size()) &&
                            stats->all_program_ids[seq.id];
 
   // program exists and protected?
@@ -364,9 +361,8 @@ void OeisManager::update(bool force) {
       Log::get().info("Updating OEIS index (last update " +
                       std::to_string(oeis_age_in_days) + " days ago)");
     }
-    std::string cmd, path;
-    for (auto &file : files) {
-      path = Setup::getOeisHome() + file;
+    for (const auto &file : files) {
+      const auto path = Setup::getOeisHome() + file;
       ApiClient::getDefaultInstance().getOeisFile(file, path);
     }
   }
@@ -400,9 +396,9 @@ void OeisManager::update(bool force) {
         Setup::getMiningMode() == MiningMode::MINING_MODE_CLIENT) {
       Log::get().info("Cleaning up local programs directory");
       int64_t num_removed = 0;
-      for (const auto &it : std::filesystem::directory_iterator(local_dir)) {
-        const auto stem = it.path().filename().stem().string();
-        const auto ext = it.path().filename().extension().string();
+      for (const auto &f : std::filesystem::directory_iterator(local_dir)) {
+        const auto stem = f.path().filename().stem().string();
+        const auto ext = f.path().filename().extension().string();
         bool is_program;
         try {
           OeisSequence s(stem);
@@ -411,10 +407,10 @@ void OeisManager::update(bool force) {
           is_program = stem.rfind("api-", 0) == 0;
         }
         is_program = is_program && (ext == ".asm");
-        const auto p = it.path().string();
+        const auto p = f.path().string();
         if (is_program && getFileAgeInDays(p) > max_age) {
           Log::get().debug("Removing \"" + p + "\"");
-          std::filesystem::remove(it.path());
+          std::filesystem::remove(f.path());
           num_removed++;
         }
       }
@@ -444,7 +440,7 @@ void OeisManager::generateStats(int64_t age_in_days) {
   bool has_program, has_formula;
 
   AdaptiveScheduler notify(20);  // magic number
-  for (auto &s : sequences) {
+  for (const auto &s : sequences) {
     if (s.id == 0) {
       continue;
     }
@@ -524,8 +520,8 @@ void OeisManager::generateLists() {
   // write lists
   ensureDir(lists_home);
   for (size_t i = 0; i < list_files.size(); i++) {
-    auto buf = list_files[i].str();
-    if (!buf.empty()) {
+    const auto f = list_files[i].str();
+    if (!f.empty()) {
       const std::string list_path =
           lists_home + "list" + std::to_string(i) + ".markdown";
       OeisSequence start(std::max<int64_t>(i * list_file_size, 1));
@@ -539,7 +535,7 @@ void OeisManager::generateLists() {
       list_file << "---\n";
       list_file << "List of integer sequences with links to LODA programs."
                 << "\n\n";
-      list_file << buf;
+      list_file << f;
       list_file << "\n\n[License Info](https://github.com/loda-lang/"
                    "loda-programs#license)\n";
     }
@@ -553,7 +549,6 @@ void OeisManager::generateLists() {
 }
 
 void OeisManager::migrate() {
-  Settings settings;
   Interpreter interpreter(settings);
   IncrementalEvaluator ie(interpreter);
   for (size_t id = 0; id < 400000; id++) {
@@ -582,9 +577,9 @@ void OeisManager::migrate() {
                        op.source == Operand(Operand::Type::CONSTANT, 1)) {
               Log::get().warn("Migrating " + ProgramUtil::getProgramPath(s.id));
               op.type = Operation::Type::TRN;
-              std::ofstream out(ProgramUtil::getProgramPath(s.id));
-              ProgramUtil::print(p, out);
-              out.close();
+              std::ofstream fout(ProgramUtil::getProgramPath(s.id));
+              ProgramUtil::print(p, fout);
+              fout.close();
               loop_started = false;
             }
           }
@@ -673,7 +668,7 @@ void OeisManager::dumpProgram(size_t id, Program &p, const std::string &file,
   Comments::removeComments(p);
   addSeqComments(p);
   ensureDir(file);
-  auto &seq = sequences.at(id);
+  const auto &seq = sequences.at(id);
   Program tmp;
   Operation nop(Operation::Type::NOP);
   nop.comment = seq.to_string();
@@ -710,7 +705,7 @@ void OeisManager::dumpProgram(size_t id, Program &p, const std::string &file,
 void OeisManager::alert(Program p, size_t id, const std::string &prefix,
                         const std::string &color,
                         const std::string &submitted_by) const {
-  auto &seq = sequences.at(id);
+  const auto &seq = sequences.at(id);
   std::string msg, full;
   msg = prefix + " program for " + seq.to_string();
   full = msg + " Terms: " + seq.getTerms(settings.num_terms).to_string();
@@ -936,7 +931,6 @@ std::vector<Program> OeisManager::loadAllPrograms() {
   const auto num_ids = program_ids.size();
   const auto num_programs = getStats().num_programs;
   std::vector<Program> programs(num_ids);
-  Parser parser;
   Log::get().info("Loading " + std::to_string(num_programs) + " programs");
   AdaptiveScheduler scheduler(20);
   int64_t loaded = 0;