colourscheme override #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this further with my own fork to merge this and another MR I've submitted plus my own config and it works really well to allow me to override things in the theme without having to make changes upstream. This completely removes the need for me to maintain a fork to make changes and is much easier to deal with for everyone IMO. |
|
Thx a lot. Can you edit the A clearer example showcasing the overrideScheme is preferable |
|
That should provide such an example, if an image is required, please let me know. |
|
That's nice. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should complete #106
Please let me know if anything needs to be done for this and I can add that as required.
I have tested this and it works as expected, one caveat is that changing filter or colorscheme will not necessarily change the colours as it is possible to change the base colours from this method.