si57x_ctrl: add timeout to busy polling. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SI57x IC isn't on the I2C bus, I2C transactions might never conclude, leaving the si57x_ctrl core perenially busy. This situation can happen with BPM boards which aren't fitted with digitizer boards on both of its FMC slots. Since we added the get_busy() function in order to simplify the implementation of still_busy(), we also use it in write_params(), to avoid repetition. The 2 second timeout was defined by the FPGA core developer, @augustofg.
|
henriquesimoes
approved these changes
Feb 11, 2025
gustavosr8
approved these changes
Feb 11, 2025
|
This has now been tested on the homolog crate to not affect normal operation. The new issue pointed out by SonarCloud is a false positive, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SI57x IC isn't on the I2C bus, I2C transactions might never conclude, leaving the si57x_ctrl core perenially busy. This situation can happen with BPM boards which aren't fitted with digitizer boards on both of its FMC slots.
Since we added the get_busy() function in order to simplify the implementation of still_busy(), we also use it in write_params(), to avoid repetition.
The 2 second timeout was defined by the FPGA core developer, @augustofg.