Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
lndrtrbn committed Oct 12, 2020
1 parent 5907a36 commit a64779a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Each component is commented to explain the code.
> (Note.2) There is no optimisation in requests made to the NASA API to ease the number of resquests made. Optimisations that can easily be made by storing in memory the days already asked before. But, again, it was not the purpose of the project which is just an exemple of architecture.
> (Note.3) After running the project, you probably see some 404 pictures. It's because the API not only provides pictures but sometimes videos. For simplicity, I managed only pictures content and place a default 404 image when the content is something else.
## Prepare your environment

If you try to start the project you will get an error involving a `secret.ts` file that is not in the repository. As I said I use an open API made by the NASA. I didn't write any backend server to manage the calls to this API, I made it directly in the Angular project for the sake of simplicity. So I need the API key in the Angular project, and, for sure I don't want to push this key on the repository.
Expand Down

0 comments on commit a64779a

Please sign in to comment.