Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove ecs-8.x.php files to simplify configuration #96

Merged
merged 1 commit into from
May 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,12 @@ use Symplify\EasyCodingStandard\Config\ECSConfig;

return ECSConfig::configure()
->withPaths([__DIR__ . '/src', __DIR__ . '/tests']) // optionally add 'config' or other directories with PHP files
->withRootFiles() // to include ecs.php and all other php files in the root directory
->withRootFiles() // to also check ecs.php and all other php files in the root directory
->withSets(
[
__DIR__ . '/vendor/lmc/coding-standard/ecs.php',
]
);

// By default, only checks compatible with PHP 8.0 are enabled.
// Depending on the lowest PHP version your project needs to support, you can enable additional checks.

// Import one of ecs-8.1.php, ecs-8.2.php or ecs-8.3.php. Use only one additional file (for the highest possible
// PHP version), the configs for previous versions are automatically included.
//->withSets(
// [
// __DIR__ . '/vendor/lmc/coding-standard/ecs.php',
// __DIR__ . '/vendor/lmc/coding-standard/ecs-8.3.php',
// ]
//);
```

2. Run the check command
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"vendor/bin/ecs check --config=ecs-internal.php --ansi --fix"
],
"lint": [
"vendor/bin/parallel-lint -j 10 -e php ./src ./tests ecs.php ecs-8.1.php ecs-8.2.php ecs-8.3.php",
"vendor/bin/parallel-lint -j 10 -e php ./src ./tests ecs.php",
"@composer validate",
"@composer normalize --dry-run"
],
Expand Down
5 changes: 0 additions & 5 deletions ecs-8.1.php

This file was deleted.

6 changes: 0 additions & 6 deletions ecs-8.2.php

This file was deleted.

6 changes: 0 additions & 6 deletions ecs-8.3.php

This file was deleted.