Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anatomy basis on the Left Hand #8

Open
cavalleria opened this issue Aug 11, 2023 · 6 comments
Open

Anatomy basis on the Left Hand #8

cavalleria opened this issue Aug 11, 2023 · 6 comments

Comments

@cavalleria
Copy link

image
我发现右手的三个轴拇指是符合生理学的,但是左手拇指好像不太符合

@cavalleria
Copy link
Author

image
我把左手的拇指三个轴改成(-1,1,1)看起来可以了

@cavalleria
Copy link
Author

还有个问题,左手手腕的轴和其他手指也不太一样,可以把这儿的b_axis_init改成(-1,0,0)https://github.com/lixiny/manotorch/blob/5738d327a343e7533ad60da64d1629cedb5ae9e7/manotorch/axislayer.py#L37C10-L37C10

@LongIslandWithoutIceTea
Copy link

LongIslandWithoutIceTea commented Aug 15, 2023

I encountered similar issues and I have applied a solution only on the left hand:

  1. Set b_axis_init (at least the one that corresponds to the root joint) to (-1, 0, 0)
  2. Multiply the first dimension of up_axis_base with -1 (since I have changed the up_axis_base according to my own need)

Maybe I can create a PR for this fix

@lixiny
Copy link
Owner

lixiny commented Sep 14, 2023

Thanks for your discussion.

Indeed, current anatomy basis in manotorch only works for right hand.
However, you already find a solution for the left hand. 😸

@lixiny lixiny pinned this issue Sep 14, 2023
@lixiny lixiny changed the title thumb of the AxisAdaptiveLayer initially selected (1,1,1) as the basis Anatomy basis on the Left Hand Sep 14, 2023
@liangzhenghao2000
Copy link

可能是原mano文件的问题?有带shape吗?vchoutas/smplx#48

@lixiny
Copy link
Owner

lixiny commented Dec 17, 2024

manotorch's anatomical system now support Left Hand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants