'Duration' import from '@bufbuild/protobuf' results in a none working sdk/cli

[enimatek-nl]

node-sdks/packages/livekit-server-sdk/src/SipClient.ts

Line 4 in 12ca25c

import { Duration } from '@bufbuild/protobuf';

When starting an Agent(js) Node, Deno and Bun fail on this import line.

1 | (function (entry, fetcher)
    ^
SyntaxError: Export named 'Duration' not found in module '[...]/node_modules/@bufbuild/protobuf/dist/esm/index.js'.

Removing it solves the issue.

The import seems to be a mistake by the last commit, since it has no purpose afaik.

[valdrox]

There's an open PR for this I believe. The following fixed it for me in the meantime:

// .pnpmfile.cjs

module.exports = {
  hooks: {
    readPackage(pkg) {
      if (pkg.name === 'livekit-server-sdk') {
        // the problem is outlined here https://github.com/livekit/node-sdks/pull/351
        // Check if the devDependencies contains "@bufbuild/protobuf"
        if (pkg.dependencies && !pkg.dependencies['@bufbuild/protobuf']) {
          // Add it to dependencies
          pkg.dependencies['@bufbuild/protobuf'] = '^1.7.2';
        }
      }
      return pkg;
    },
  },
};

[lukasIO]

thanks for the report, this got indeed fixed in #351