Update data stream API (#405)

livekit · Jan 31, 2025 · f32e411 · f32e411
1 parent a5311f8
commit f32e411
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/examples/data-streams/index.ts b/examples/data-streams/index.ts
@@ -36,7 +36,7 @@ const sendFile = async (room: Room, recipient: RemoteParticipant) => {
   await room.localParticipant?.sendFile('./assets/maybemexico.jpg', {
     destinationIdentities: [recipient.identity],
     name: 'mex.jpg',
-    topic: 'welcome',
+    topic: 'files',
     mimeType: 'image/jpg',
   });
   console.log('done sending file');
@@ -53,14 +53,14 @@ const main = async () => {
     room.on(RoomEvent.ParticipantDisconnected, resolve);
   });
 
-  room.setTextStreamHandler(async (reader: TextStreamReader, { identity }) => {
+  room.registerTextStreamHandler('chat', async (reader: TextStreamReader, { identity }) => {
     console.log(`chat message from ${identity}: ${await reader.readAll()}`);
     // for await (const { collected } of reader) {
     //   console.log(collected);
     // }
-  }, 'chat');
+  });
 
-  room.setByteStreamHandler(async (reader: ByteStreamReader, { identity }) => {
+  room.registerByteStreamHandler('files', async (reader: ByteStreamReader, { identity }) => {
     console.log(`welcome image received from ${identity}: ${reader.info.name}`);
 
     // create write stream and write received file to disk, make sure ./temp folder exists
@@ -70,7 +70,7 @@ const main = async () => {
       writer.write(chunk);
     }
     writer.close();
-  }, 'welcome');
+  });
 
   room.on(RoomEvent.ParticipantConnected, async (participant) => {
     await sendFile(room, participant);

diff --git a/packages/livekit-rtc/src/room.ts b/packages/livekit-rtc/src/room.ts
@@ -194,25 +194,25 @@ export class Room extends (EventEmitter as new () => TypedEmitter<RoomCallbacks>
     this.removeAllListeners();
   }
 
-  setTextStreamHandler(callback: TextStreamHandler, topic: string = '') {
+  registerTextStreamHandler(topic: string, callback: TextStreamHandler) {
     if (this.textStreamHandlers.has(topic)) {
-      throw new TypeError(`A text stream handler for topic "${topic}" has already been set.`);
+      throw new Error(`A text stream handler for topic "${topic}" has already been set.`);
     }
     this.textStreamHandlers.set(topic, callback);
   }
 
-  removeTextStreamHandler(topic: string = '') {
+  unregisterTextStreamHandler(topic: string) {
     this.textStreamHandlers.delete(topic);
   }
 
-  setByteStreamHandler(callback: ByteStreamHandler, topic: string = '') {
+  registerByteStreamHandler(topic: string, callback: ByteStreamHandler) {
     if (this.byteStreamHandlers.has(topic)) {
-      throw new TypeError(`A byte stream handler for topic "${topic}" has already been set.`);
+      throw new Error(`A byte stream handler for topic "${topic}" has already been set.`);
     }
     this.byteStreamHandlers.set(topic, callback);
   }
 
-  removeByteStreamHandler(topic: string = '') {
+  unregisterByteStreamHandler(topic: string) {
     this.byteStreamHandlers.delete(topic);
   }