Add operator interface for Probe pkg #4849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add probeOperator to probe pkg - Add probeOperator to handler that uses probeUtils - Add probe operator as parameter to functions that use probe operations in probeUtils Signed-off-by: sukkyun2 <goobghd@gmail.com>
Signed-off-by: sukkyun2 <goobghd@gmail.com>
- Apply goimports Signed-off-by: sukkyun2 <goobghd@gmail.com>
sukkyun2
force-pushed
the
refactor/add-operator-interface
branch
from
579cec1
to
5186dbf
Compare
Saranya-jena
approved these changes
Sep 6, 2024
namkyu1999
approved these changes
Sep 6, 2024
|
can you check a build-pipeline? @sukkyun2 |
Signed-off-by: sukkyun2 <goobghd@gmail.com>
namkyu1999
approved these changes
Sep 6, 2024
S-ayanide
requested changes
Sep 9, 2024
- Updated handler to call GenerateExperimentManifestWithProbes, GenerateCronExperimentManifestWithProbes via ProbeService Signed-off-by: sukkyun2 <goobghd@gmail.com>
- add mock probeService generated by mockery Signed-off-by: sukkyun2 <goobghd@gmail.com>
Signed-off-by: sukkyun2 <goobghd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds operator interface to probe pkg
#4836, I tried to add fuzz test for probe handler.
However, the current architecture made it impossible to mock probe operations, so I added probe operator interface.
This picture is about probe pkg.
References
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
I need feedback on the approach of passing
probeOperatoras a parameter to functions.For example, the function
GenerateExperimentManifestWithProbesin chaoscenter/graphql/server/pkg/probe/utils/utils.go directly accesses probe operation. I have added theprobeOperatordependency to the handler that usesGenerateExperimentManifestWithProbesand updated the function calls to passprobeOperatoras a parameter.