Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logic to check existence of Secrets for ChaosExperiments #18

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Added Logic to check existence of Secrets for ChaosExperiments #18

merged 1 commit into from
Oct 12, 2020

Conversation

christopherfriedrich
Copy link
Member

Signed-off-by: christopherfriedrich christopher.friedrich@haw-hamburg.de

What this PR does / why we need it:

  • Checks the existence of the referenced Secrets in all ChaosExperiments and reports the missing ones

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #14

Special notes for your reviewer:

Checklist:

  • Fixes Add validation for ChaosExperiment's Secrets #14
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: christopherfriedrich <christopher.friedrich@haw-hamburg.de>
@christopherfriedrich
Copy link
Member Author

I want to add some unit tests this time with regard to #2, but i'm unsure how to name the corresponding file webhook_test or appFilterCheck_test ?

@christopherfriedrich christopherfriedrich marked this pull request as ready for review October 12, 2020 09:14
@rahulchheda
Copy link
Member

Hey @christopherfriedrich , I was thinking to follow up with an issue on that conversation, but thanks for understnding the context, and getting a PR out of it.
For tests, I think the betterway would be just add unit tests, for appFilterCheck.go i.e appFilterCheck_test.go. Let me know if you need any help for it.

Copy link
Member

@rahulchheda rahulchheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ksatchit ksatchit merged commit b253e40 into litmuschaos:master Oct 12, 2020
@christopherfriedrich christopherfriedrich deleted the validateExperimentsSecrets branch October 12, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for ChaosExperiment's Secrets
3 participants