This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Enable Lita to handle messages from other bots (again) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikogan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading our branch to include 1.8.0 AND #64, our Lita bot stopped responding to messages from other bots. This is because
bot_messageis not in the whitelist of supported message subtypes.I suspect this may have been a deliberate change, however we have a number of systems that invoke actions on Lita through Slack. I’ve added a configuration option to re-enable these interactions.
Some thoughts:
falseif you prefer, since this is now the default behavior since sometime after 1.7.2.handle_bot_messages, to be honest.