Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move provision script to CLI #603

Open
ccrvlh opened this issue Dec 13, 2022 · 5 comments
Open

Move provision script to CLI #603

ccrvlh opened this issue Dec 13, 2022 · 5 comments
Assignees
Labels
kind/feature New feature or request

Comments

@ccrvlh
Copy link

ccrvlh commented Dec 13, 2022

Describe the solution you'd like:
As of now, the provision.sh does most of the heavy lifting to setup Flintlock and dependencies (Firecracker, containerd, networking etc) to a host machine. The idea is to port this script to a CLI.

Why do you want this feature:
Even though the script works great, having this feature in a CLI would make for a better developer experience, and probably easier to maintain and extend.

I believe there's still the discussion of whether this should be part of the flintlock CLI or maybe of a client (similar to what was discussed here), I ended up creating a repo to start working on this, very early stages still. We can later decide where we want that to live. If anyone else also wants to work on this, we could easily just move that to a branch inside fl or flintlock though.

About the code itself, there's also the decision to use exec.Command vs adding more dependencies (for example, DIgitalOcean maintains a SDK to interact with libvirtd), just something to consider.

@ccrvlh ccrvlh added the kind/feature New feature or request label Dec 13, 2022
@Callisto13 Callisto13 moved this from Backlog to In Progress in Liquid Metal Roadmap - Public Dec 14, 2022
@Callisto13
Copy link
Member

another note on the cli for this: in the past we have used spf13/cobra, but we are making a conscious effort to replace that and use urfave/cli instead

@ccrvlh
Copy link
Author

ccrvlh commented Dec 14, 2022

Noted, I saw that discussion in the past (I think it was driven by containerd's use of urfave/cli?) and started the project with urfave as well.

PS: Noticed the repo link was private, just changed that to public.

@Callisto13
Copy link
Member

Callisto13 commented Dec 14, 2022

(I think it was driven by containerd's use of urfave/cli?)

10% that, 90% i just don't like cobra 😂

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Liquid Metal Roadmap - Public May 18, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
No open projects
Status: Closed
Development

No branches or pull requests

3 participants