Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no longer needed django-ckeditor package #1744

Merged
merged 2 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/_0001.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
### Changed

- tests: replace the ckeditor fields with TextField in migrations to be able to remove the django-ckeditor package

### Removed

- remove the no longer needed django-ckeditor package, the transition to
django-ckeditor-5 has been done now.
1 change: 0 additions & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Django==4.2.16
django-allauth==65.3.1
django-autoslug==1.9.9
https://github.com/liqd/django-ckeditor-5/releases/download/v0.2.11-liqd/django_ckeditor_5-0.2.11-py3-none-any.whl
django-ckeditor==6.7.1
django-enumfield==3.1
django-filter==24.3
django-widget-tweaks==1.5.0
Expand Down
5 changes: 1 addition & 4 deletions tests/apps/ideas/migrations/0001_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import adhocracy4.categories.fields
import adhocracy4.maps.fields
import ckeditor.fields
from django.db import migrations, models
import django.db.models.deletion

Expand Down Expand Up @@ -41,9 +40,7 @@ class Migration(migrations.Migration):
),
(
"description",
ckeditor.fields.RichTextField(
blank=True, verbose_name="Description"
),
models.TextField(blank=True, verbose_name="Description"),
),
("point", adhocracy4.maps.fields.PointField(blank=True)),
(
Expand Down
3 changes: 1 addition & 2 deletions tests/apps/moderatorfeedback/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Generated by Django 3.2.7 on 2021-09-28 09:59

import ckeditor.fields
import django.utils.timezone
from django.conf import settings
from django.db import migrations, models
Expand Down Expand Up @@ -36,7 +35,7 @@ class Migration(migrations.Migration):
"modified",
models.DateTimeField(blank=True, editable=False, null=True),
),
("statement", ckeditor.fields.RichTextField(blank=True)),
("statement", models.TextField(blank=True)),
(
"creator",
models.ForeignKey(
Expand Down