remove no longer needed django-ckeditor package #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goapunk some imports of ckeditor in templatetags need removal for tests to pass. |
goapunk
force-pushed
the
jd-2025-01-remove-django-ckeditor
branch
from
ad74791 to
2fd23d0
Compare
|
@m4ra fixed the test migrations now |
goapunk
commented
Jan 6, 2025
| import django_ckeditor_5.fields | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): |
There was a problem hiding this comment.
@m4ra tbh I'm not entirely sure why it created this one just now
There was a problem hiding this comment.
Because the 0006 has textfield, while the idea model has ckeditor 5. You don't need to change the 0006.
There was a problem hiding this comment.
oh, good catch, I totally missed that it's already ckeditor5 🤯
m4ra
requested changes
Jan 6, 2025
| import django_ckeditor_5.fields | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): |
There was a problem hiding this comment.
Because the 0006 has textfield, while the idea model has ckeditor 5. You don't need to change the 0006.
goapunk
force-pushed
the
jd-2025-01-remove-django-ckeditor
branch
from
2fd23d0 to
a7e5f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks