Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7885] replace multiselect with m2m relation for project topics #1515

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[7885] replace multiselect with m2m relation for project topics #1515

merged 2 commits into from
Dec 12, 2023

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Dec 11, 2023 •
edited
Loading

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.57% 44/350
🔴 Lines 20.58% 725/3523

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ee18d9d

@goapunk goapunk force-pushed the jd-2023-12-topic-names-test branch 2 times, most recently from 1087905 to 22b10df Compare December 12, 2023 09:58
@goapunk goapunk requested a review from m4ra December 12, 2023 09:59
m4ra
m4ra approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like to add a docs about how we handle topics for projects which make use of this. I will add an extra commit to this PR.

@goapunk goapunk force-pushed the jd-2023-12-topic-names-test branch from 22b10df to ec16a09 Compare December 12, 2023 10:15
@m4ra m4ra force-pushed the jd-2023-12-topic-names-test branch 2 times, most recently from 78755b5 to a2d20cd Compare December 12, 2023 12:04
@m4ra m4ra force-pushed the jd-2023-12-topic-names-test branch from a2d20cd to 635a3d2 Compare December 12, 2023 14:07
@m4ra m4ra changed the title tests/projects: add test for topic_names [7885] replace multiselect with m2m relation for project topics Dec 12, 2023
goapunk
goapunk commented Dec 12, 2023
View reviewed changes
adhocracy4/projects/fields.py Outdated


class TopicField(MultiSelectField):
class TopicField(models.CharField):
"""Deprecated, don't use"""

# TODO: remove once topic migrations are rolled out
def __init__(self, *args, **kwargs):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove all methods and just add pass as it's unused anyway?

@m4ra m4ra force-pushed the jd-2023-12-topic-names-test branch from 635a3d2 to ee18d9d Compare December 12, 2023 14:19
@goapunk goapunk merged commit 41706a3 into main Dec 12, 2023
2 checks passed
@goapunk goapunk deleted the jd-2023-12-topic-names-test branch December 12, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra m4ra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @m4ra