Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckeditor: add templatetag which disables iframes if javascript is dis… #1506

Merged
merged 1 commit into from
Nov 22, 2023
Merged

ckeditor: add templatetag which disables iframes if javascript is dis… #1506

merged 1 commit into from
Nov 22, 2023

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Nov 22, 2023 •
edited
Loading

…abled

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk mentioned this pull request Nov 22, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.57% 44/350
🔴 Lines 20.58% 725/3523

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from b345ceb

@goapunk goapunk force-pushed the jd-2023-11-ckeditor-iframes branch from 3039aa8 to b345ceb Compare November 22, 2023 14:30
@goapunk goapunk requested a review from hom3mad3 November 22, 2023 14:31
@hom3mad3
Copy link
Contributor

hom3mad3 commented Nov 22, 2023 •
edited
Loading

@goapunk not too sure how to test it. do we have a fallback in place? does it display a message to the user of some sort?
is this something the plugin dsgvo-video-embed is taking care of?

hom3mad3
hom3mad3 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hom3mad3 hom3mad3 merged commit a7b33d6 into main Nov 22, 2023
2 checks passed
@hom3mad3 hom3mad3 deleted the jd-2023-11-ckeditor-iframes branch November 22, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hom3mad3 hom3mad3 hom3mad3 approved these changes

@m4ra m4ra Awaiting requested review from m4ra

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @hom3mad3