-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8306] more cleanup #2691
Merged
Merged
[8306] more cleanup #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
changed the base branch from
main
to
jd-2024-09-delete-opin-apps-part2
September 12, 2024 14:57
actually I think this is still WIP and needs some work, let me check |
goapunk
force-pushed
the
jd-2024-09-delete-opin-apps-part2
branch
from
October 21, 2024 11:25
12f92b2
to
12c0976
Compare
goapunk
force-pushed
the
jd-2024-09-delete-opin-apps-part3
branch
from
October 22, 2024 10:41
1ae8b8f
to
6e0672a
Compare
goapunk
force-pushed
the
jd-2024-09-delete-opin-apps-part3
branch
from
October 22, 2024 12:00
6e0672a
to
6273cd8
Compare
m4ra
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup up some more stuff which is not needed anymore.
This PR needs to be merged after #2690 was deployed!