Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8306] more cleanup #2691

Merged
merged 11 commits into from
Oct 22, 2024
Merged

[8306] more cleanup #2691

merged 11 commits into from
Oct 22, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Sep 12, 2024

cleanup up some more stuff which is not needed anymore.

This PR needs to be merged after #2690 was deployed!

@goapunk goapunk changed the base branch from main to jd-2024-09-delete-opin-apps-part2 September 12, 2024 14:57
@goapunk goapunk changed the title [8306] more cleanup WIP: [8306] more cleanup Sep 16, 2024
@goapunk goapunk changed the title WIP: [8306] more cleanup [8306] more cleanup Oct 21, 2024
@goapunk goapunk changed the title [8306] more cleanup WIP: [8306] more cleanup Oct 21, 2024
@goapunk
Copy link
Contributor Author

goapunk commented Oct 21, 2024

actually I think this is still WIP and needs some work, let me check

@goapunk goapunk force-pushed the jd-2024-09-delete-opin-apps-part2 branch from 12f92b2 to 12c0976 Compare October 21, 2024 11:25
Base automatically changed from jd-2024-09-delete-opin-apps-part2 to main October 22, 2024 09:34
@goapunk goapunk force-pushed the jd-2024-09-delete-opin-apps-part3 branch from 1ae8b8f to 6e0672a Compare October 22, 2024 10:41
@goapunk goapunk requested a review from m4ra October 22, 2024 10:41
@goapunk goapunk force-pushed the jd-2024-09-delete-opin-apps-part3 branch from 6e0672a to 6273cd8 Compare October 22, 2024 12:00
@goapunk goapunk changed the title WIP: [8306] more cleanup [8306] more cleanup Oct 22, 2024
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@m4ra m4ra merged commit bc9feea into main Oct 22, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-09-delete-opin-apps-part3 branch October 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants