Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8827] cms/project-teaser-block: add project teaser block #6020

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 30, 2025

Describe your changes
CleanShot 2025-01-30 at 15 53 26

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip requested a review from hom3mad3 January 30, 2025 14:54
@@ -18,6 +18,28 @@ class Meta:
icon = "list-ul"


class ProjectTeaserBlock(blocks.StructBlock):
headline = blocks.CharBlock(max_length=100)
overwrite_title = blocks.CharBlock(
Copy link
Contributor

@hom3mad3 hom3mad3 Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names overwrite_title and overwrite_teaser might not make sense for an editor, so I would keep the object name consistent with the intention. Maybe custom_title and custom_teaser would be clearer? Also, the help text could be clearer:

  • Custom Title: "Replaces the default project title if set."
  • Custom Teaser: "Replaces the default teaser text if set."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants