Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IP logging #73

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Added IP logging #73

merged 7 commits into from
Apr 6, 2024

Conversation

homerr
Copy link
Member

@homerr homerr commented Mar 29, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Added logging to the duck.log file to include the discovered IP address(es)

Benefits of this PR and context:

Closes issue #72 feature request

How Has This Been Tested?

Tested locally with success;

Detecting IPv4 via CloudFlare
Your IP was updated at Fri Mar 29 09:26:54 UTC 2024 to IPv4: 82.44.x.x

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/a4b08902-pkg-a4b08902-dev-5bf5a82d6b1aff4c009ba0f394924aaec2198cd1-pr-73/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/a4b08902-pkg-a4b08902-dev-5bf5a82d6b1aff4c009ba0f394924aaec2198cd1-pr-73/shellcheck-result.xml

Tag Passed
amd64-a4b08902-pkg-a4b08902-dev-5bf5a82d6b1aff4c009ba0f394924aaec2198cd1-pr-73
arm64v8-a4b08902-pkg-a4b08902-dev-5bf5a82d6b1aff4c009ba0f394924aaec2198cd1-pr-73

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/a4b08902-pkg-a4b08902-dev-52f0e81c27e6aaff2683a58ca1cd533b072e5383-pr-73/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/a4b08902-pkg-a4b08902-dev-52f0e81c27e6aaff2683a58ca1cd533b072e5383-pr-73/shellcheck-result.xml

Tag Passed
amd64-a4b08902-pkg-a4b08902-dev-52f0e81c27e6aaff2683a58ca1cd533b072e5383-pr-73
arm64v8-a4b08902-pkg-a4b08902-dev-52f0e81c27e6aaff2683a58ca1cd533b072e5383-pr-73

@homerr homerr self-assigned this Mar 30, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-af9e0a2453b892327209554534acf3560dcf77d8-pr-73/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-af9e0a2453b892327209554534acf3560dcf77d8-pr-73/shellcheck-result.xml

Tag Passed
amd64-4fb95cad-pkg-4fb95cad-dev-af9e0a2453b892327209554534acf3560dcf77d8-pr-73
arm64v8-4fb95cad-pkg-4fb95cad-dev-af9e0a2453b892327209554534acf3560dcf77d8-pr-73

Copy link
Member Author

@homerr homerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are good!

@aptalca aptalca requested a review from a team April 1, 2024 20:37
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-98e9484df99f3b446d2aac10feb008dae157d0ae-pr-73/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-98e9484df99f3b446d2aac10feb008dae157d0ae-pr-73/shellcheck-result.xml

Tag Passed
amd64-4fb95cad-pkg-4fb95cad-dev-98e9484df99f3b446d2aac10feb008dae157d0ae-pr-73
arm64v8-4fb95cad-pkg-4fb95cad-dev-98e9484df99f3b446d2aac10feb008dae157d0ae-pr-73

@homerr
Copy link
Member Author

homerr commented Apr 6, 2024

@aptalca should be good to merge now if I could have your approval :)

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-bd6972cab277c517fbdbf556e8c73f8ffa96dc28-pr-73/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/4fb95cad-pkg-4fb95cad-dev-bd6972cab277c517fbdbf556e8c73f8ffa96dc28-pr-73/shellcheck-result.xml

Tag Passed
amd64-4fb95cad-pkg-4fb95cad-dev-bd6972cab277c517fbdbf556e8c73f8ffa96dc28-pr-73
arm64v8-4fb95cad-pkg-4fb95cad-dev-bd6972cab277c517fbdbf556e8c73f8ffa96dc28-pr-73

@homerr homerr merged commit eb17b8c into master Apr 6, 2024
4 checks passed
@homerr homerr deleted the add-address-echo branch April 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants