Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9421] - Add API endpoints and types for /v4/nodebalancers #11832

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

harsh-akamai
Copy link
Contributor

Description 📝

Add new /v4/nodebalancers (& /v4beta/nodebalancers) endpoints for NB-VPC Integration

How to test 🧪

  • confirm changes match API spec
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing533 Passing4 Skipped108m 3s

Details

Failing Tests
SpecTest
edit-user-alert.spec.tsIntegration Tests for Edit Alert » should correctly display the details of the alert in the Edit Alert page
object-storage.e2e.spec.tsobject storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/edit-user-alert.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

@dwiley-akamai dwiley-akamai added the NB-VPC Relating to NodeBalancer-VPC integration label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NB-VPC Relating to NodeBalancer-VPC integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants