test [M3_8070]: Linting autofixes

[dmcintyr-akamai]

Description 📝

Previous PRs under M3_8070 fixed linting errors in the cypress directory. This pr is the result of running npx eslint cypress/e2e/core --fix in the packages/manager directory. This pr applies linting standards to autofix issues in the files. It does not fix all the warnings in the files.

Almost all the changes in this pr are in the packages/manager/cypress/e2e/core. Most of the changes are the result of applying the perfectionist eslint plugin. The most common changes are: reordering of import statements, alphabetical ordering of object attributes, and formatting (indentations, spacing, returns).

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All unit tests are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[dmcintyr-akamai]

The cloud-manager-component-tests reports a failure, but if i re-run the test locally (pnpm run cy:component:run) all the tests succeed. It's unlikely this pr would break the unit tests bc i'm not modifying the code in the src directory.

There is a slight risk that these changes would break some e2e tests by reordering object attribues (some formatting functions are brittle and rely upon the ordering of object attributes, which we have to overrule w/ the "eslint-disable perfectionist/sort-objects" directive) but all the e2e tests are passing.

[linode-gh-bot]

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
1 Failing	537 Passing	3 Skipped	107m 38s

Details

Failing Tests
	Spec	Test
❌	create-firewall.spec.ts	create firewall » creates a firewall without a linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts"

[dmcintyr-akamai]

fwiw cypress/e2e/core/firewalls/create-firewall.spec.ts passes for me locally