-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-23781] - Error handling while enabling/disabling alerts in Monitor #11813
Open
ankita-akamai
wants to merge
10
commits into
linode:develop
Choose a base branch
from
ankita-akamai:feature/ErrorHandlingEnableDisable
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
upcoming: [DI-23781] - Error handling while enabling/disabling alerts in Monitor #11813
ankita-akamai
wants to merge
10
commits into
linode:develop
from
ankita-akamai:feature/ErrorHandlingEnableDisable
+242
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urls for metrics and alerts in cypress needs to be changed once mega menu changes are merged. This pr will be merged after successfully rebasing it post merge of - #11803 |
Cloud Manager UI test results🎉 539 passing tests on test run #5 ↗︎
|
Coverage Report: ✅ |
venkymano-akamai
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Error handling while enabling/disabling alerts in Monitor.
Changes 🔄
Note: Error messages will be shown in snackbars.
Target release date 🗓️
Next Release
Preview 📷
No error message received from api:

Error message received from api:
|
How to test 🧪
Verification steps
(How to verify changes)
see screenshot 👇

serverhandler.ts
file and try sending an error with a dummy message in the update call. (search for a put call receiving url ending with/alert-definitions/:id
).Enable
orDisable
listed in action menu.Enabling alert failed
orDisabling alert failed
.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅