Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-23781] - Error handling while enabling/disabling alerts in Monitor #11813

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ankita-akamai
Copy link
Contributor

Description 📝

Error handling while enabling/disabling alerts in Monitor.

Changes 🔄

  • Show custom error message if an errored response with no message is received while enabling or disabling alerts.
  • If there is an error message received from the api in the above case, show that message.
    Note: Error messages will be shown in snackbars.

Target release date 🗓️

Next Release

Preview 📷

No error message received from api:
image

Error message received from api:
image|

How to test 🧪

Verification steps

(How to verify changes)

see screenshot 👇
image

  • Navigate to alerts tab under monitor menu item.
  • Go to serverhandler.ts file and try sending an error with a dummy message in the update call. (search for a put call receiving url ending with /alert-definitions/:id).
  • Verify whether above error message gets reflected when you try to enable or disable an alert through the options -Enable or Disable listed in action menu.
  • In case there is an errored response with no message, a custom message from ui end will be shown at the bottom right corner of the page - Enabling alert failed or Disabling alert failed.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai
Copy link
Contributor Author

Urls for metrics and alerts in cypress needs to be changed once mega menu changes are merged. This pr will be merged after successfully rebasing it post merge of - #11803

@ankita-akamai ankita-akamai marked this pull request as ready for review March 12, 2025 08:12
@ankita-akamai ankita-akamai requested review from a team as code owners March 12, 2025 08:12
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped108m 52s

Copy link

Coverage Report:
Base Coverage: 80.11%
Current Coverage: 80.11%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants