upcoming: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs #11812
+744
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolotsk-akamai
requested review from
carrillo-erik and
hasyed-akamai
and removed request for
a team
mpolotsk-akamai
changed the title
|
Coverage Report: ✅ |
| innodb_print_all_deadlocks: true, | ||
| service_log: false, |
There was a problem hiding this comment.
DBaaS is a good candidate to move to the new mock service. Is there a ticket/scope for it?
...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx
Outdated
Show resolved
Hide resolved
...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx
Outdated
Show resolved
Hide resolved
...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx
Show resolved
Hide resolved
...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx
Show resolved
Hide resolved
…ineConfig` request to fetch all advanced configurations and updated types for advanced configs
… engine options in the drawer
mpolotsk-akamai
force-pushed
the
UIE-8515-drawer-existing-configs
branch
from
b864aab to
50f0736
Compare
Cloud Manager UI test results🎉 538 passing tests on test run #5 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Advanced Configuration - Drawer with existing configurations
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
Approximate 04/02/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅