tech-story: [M3-9483] - Add rule to prevent direct imports of Link from react-router-dom
#11801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
changed the title
react-router-domreact-router-dom
coliu-akamai
force-pushed
the
add-restricted-imports
branch
from
b367fa5 to
fecf4c2
Compare
coliu-akamai
requested review from
mjac0bs and
bnussman-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Mar 11, 2025
coliu-akamai
added
Add'tl Approval Needed
|
Coverage Report: ❌ |
mjac0bs
approved these changes
Mar 11, 2025
mjac0bs
added
Approved
Cloud Manager UI test results🔺 4 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/cloudpulse/edit-user-alert.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
||||||||||||||||||||||||||
|
smoke-landing and object-storage have been consistently failing 🤔 gonna look into them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
react-router-domsrc/components/Link+ added aria labels, or disabled the rule for files that still neededreact-router-dom's LinkHow to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅