refactor: [M3-8843] - StackScript Landing page #11215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode,
carrillo-erik and
cpathipa
and removed request for
a team
|
Coverage Report: ✅ |
|
👀 Reviewing this, but meanwhile you'll need to update to latest path for |
|
closing for now to prioritize other work |
mjac0bs
reviewed
Feb 4, 2025
There was a problem hiding this comment.
CRUD functionality is looking good with the refactoring here and tests are passing.
I was wondering about:
- disabled Create buttons for restricted users on the landing page (empty and stateful)
- addressing the Linode Create flow -> from Deploy from StackScript in another PR
- copy improvements to match our normal tone
| }); | ||
| it('gracefully handles a null image', () => { | ||
| const images = ['linode/ubuntu20.04', null, 'linode/debian9']; | ||
| // @ts-expect-error intentionally testing invalid value because API is known to return null |
There was a problem hiding this comment.
Potentially worth a ticket for maybe the full-stack team to look into?
packages/manager/src/features/StackScripts/StackScriptLanding/StackScriptActionMenu.tsx
Show resolved
Hide resolved
packages/manager/src/features/StackScripts/StackScriptLanding/StackScriptMakePublicDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/StackScripts/StackScriptLanding/StackScriptMakePublicDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/StackScripts/StackScriptLanding/StackScriptActionMenu.tsx
Show resolved
Hide resolved
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
mjac0bs
approved these changes
Feb 4, 2025
Cloud Manager UI test results🎉 495 passing tests on test run #30 ↗︎
|
carrillo-erik
approved these changes
Feb 5, 2025
cpathipa
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Nice work @bnussman-akamai!
Confirming on the functionality StackScript landing page.
cpathipa
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 17s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
500
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
StackScriptBaseHOCStackScriptBasebut that can't happen until we refactor theRebuidFromStackScriptcomponent 😮💨Preview 📷
How to test 🧪
As an Author I have considered 🤔