-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: Cloud Manager Github Pages Docs #10002
poc: Cloud Manager Github Pages Docs #10002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together this POC to compare.
When comparing between the vitepress and jekyl versions of docs, this one definitely gives us a much friendlier UX out of the box, which is really nice!
As far as the cons:
Adds a significant amount of node_modules (could cause slower install times)
Slower by some amount of seconds for install, which we don't need to do very often, is not the biggest deal, imo.
maintenance
Making sure all these new packages stay up to date and any security issues are resolved feels like a bigger pain point here. That's a lot of vue stuff we wouldn't otherwise need.
While we should consider this a con, it could be less of a problem when we migrate from yarn to pnpm or bun install
With pnpm or bun, can we skip these dependencies? Or is there something else (speed?) that would make this a different experience with alternative package managers?
@abailly-akamai That's a good idea, but I think we'd have to drop the |
@bnussman I took a super quick npx stab at it and i am feeling pretty good about it so far. Basically just with a config file in the current /docs dir + the As far as the sidebar, since we can populate it from the config file, we could write a simple script that aggregates the |
That's great news @abailly-akamai I think I'm happy with that direction. Maybe we could even copy-paste |
Closing in favor of #10027. We will continue to use Vitepress, but we will just run it with |
Description π
Tip
The site is deployed at https://bnussman-akamai.github.io/manager/ for the sake of testing this
docs
folder ποΈPros of this approach β
yarn && yarn docs
is all you need to start a local dev server (easier to onboard).md
file πCons of this approach β
Preview π·
How to test π§ͺ
Deployed
Locally
yarn
in the repo's root to ensure your dependencies are good to goyarn docs
As an Author I have considered π€