upcoming: [M3-9250] - Fix Subnet Assign and Unassign drawers for Linode Interfaces #155
Annotations
7 warnings
ESLint Review (manager):
packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx#L252
[eslint] reported by reviewdog 🐶
Unexpected any. Specify a different type.
Raw Output:
{"ruleId":"@typescript-eslint/no-explicit-any","severity":1,"message":"Unexpected any. Specify a different type.","line":252,"column":17,"nodeType":"TSAnyKeyword","messageId":"unexpectedAny","endLine":252,"endColumn":20,"suggestions":[{"messageId":"suggestUnknown","fix":{"range":[8304,8307],"text":"unknown"},"desc":"Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct."},{"messageId":"suggestNever","fix":{"range":[8304,8307],"text":"never"},"desc":"Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of."}]}
|
ESLint Review (manager):
packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx#L315
[eslint] reported by reviewdog 🐶
Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition
Raw Output:
{"ruleId":"@linode/cloud-manager/deprecate-formik","severity":1,"message":"Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition","line":315,"column":5,"nodeType":"Identifier","messageId":"formikUsage","endLine":315,"endColumn":14}
|
ESLint Review (manager):
packages/manager/src/features/VPCs/VPCDetail/SubnetUnassignLinodesDrawer.tsx#L154
[eslint] reported by reviewdog 🐶
Refactor this code to not nest functions more than 4 levels deep.
Raw Output:
{"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":154,"column":36,"nodeType":null,"endLine":154,"endColumn":38}
|
ESLint Review (manager):
packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.test.tsx#L17
[eslint] reported by reviewdog 🐶
Expected "src/factories" (src) to come before "./VPCSubnetsTable" (sibling).
Raw Output:
{"ruleId":"perfectionist/sort-imports","severity":1,"message":"Expected \"src/factories\" (src) to come before \"./VPCSubnetsTable\" (sibling).","line":17,"column":1,"nodeType":"ImportDeclaration","messageId":"unexpectedImportsGroupOrder","endLine":17,"endColumn":57,"fix":{"range":[154,576],"text":"import { firewallSettingsFactory } from 'src/factories';
|
ESLint Review (manager):
packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.test.tsx#L48
[eslint] reported by reviewdog 🐶
Define a constant instead of duplicating this literal 3 times.
Raw Output:
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":48,"column":16,"nodeType":"Literal","endLine":48,"endColumn":49}
|
ESLint Review (manager):
packages/manager/src/features/VPCs/utils.ts#L114
[eslint] reported by reviewdog 🐶
Complete the task associated to this "TODO" comment.
Raw Output:
{"ruleId":"sonarjs/todo-tag","severity":1,"message":"Complete the task associated to this \"TODO\" comment.","line":114,"column":4,"nodeType":null,"messageId":"completeTODO","endLine":114,"endColumn":8}
|
ESLint Review (manager):
packages/manager/src/features/VPCs/utils.ts#L174
[eslint] reported by reviewdog 🐶
Complete the task associated to this "TODO" comment.
Raw Output:
{"ruleId":"sonarjs/todo-tag","severity":1,"message":"Complete the task associated to this \"TODO\" comment.","line":174,"column":4,"nodeType":null,"messageId":"completeTODO","endLine":174,"endColumn":8}
|