Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft conversion of unittest syntax to pytest syntax for schema… #328

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

sierra-moxon
Copy link
Member

…view tests.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (37297a8) to head (fa27f4f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   63.44%   63.37%   -0.07%     
==========================================
  Files          63       63              
  Lines        8942     8942              
  Branches     2569     2569              
==========================================
- Hits         5673     5667       -6     
- Misses       2648     2653       +5     
- Partials      621      622       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sierra-moxon
Copy link
Member Author

prereq: linkml/linkml-model#201

Copy link
Member

@sujaypatil96 sujaypatil96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the behaviour of the tests --

  • test_induced_range_expression_with_range()
  • test_induced_range_only_range()
  • test_induced_range_only_range_expression()

I tried to review the code but I can't say that I've understood it fully. Just a quick question, similar to any_of and exactly_one_of do we need to implement special handling for none_of or all_of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants