Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in support for Python 3.6 as well as 3.7 in 1.0.7 release #257

Open
nkaminski opened this issue Oct 18, 2024 · 3 comments
Open

Comments

@nkaminski
Copy link

As of the latest release on PyPi, I have observed that this package indicates support for Python >=3.6 in its package metadata, however is presently only compatible with Python versions 3.8 or later after the introduction of commit 377c70d

Therefore, would it be possible to either:

@rillbert
Copy link

Maybe I'm missing someting in my setup but it doesn't work in my 3.8 setup either.

The type hints in the environment.py file from the commit indicated in the previous comment makes it impossible for me to run shiv at all.

A possible work-around (it works in my, so-far limited, testing) is to add the line:
from __future__ import annotations
as the first code line in environment.py.

(as mentioned here: https://stackoverflow.com/a/75317316)

@f-ewald
Copy link
Contributor

f-ewald commented Nov 1, 2024

Thank you for reporting this. I have a PR for fixing the types which changes dict to Dict.

In subsequent PR's I am also planning to address the incorrect >= 3.6 and change it to >= 3.8 to be consistent with the tests that are provided.

Finally, I am planning to add the CI pipeline to PRs so that the validation is done earlier in the process and issues can be found.

@f-ewald
Copy link
Contributor

f-ewald commented Nov 4, 2024

Version https://github.com/linkedin/shiv/releases/tag/1.0.8 has been released which should fix the regression for Python 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants