Fix for Android 15 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoser
reviewed
Nov 8, 2024
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' |
There was a problem hiding this comment.
what is this specific distribution?
| @@ -8,12 +8,17 @@ jobs: | |||
| publish: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
why dont we need a checkout action anymore? im particularly worried about this action since you can't test run it afaik
build.gradle
Outdated
| @@ -3,10 +3,11 @@ buildscript { | |||
| google() | |||
| mavenCentral() | |||
| jcenter() | |||
| mavenLocal() | |||
gradle.properties
Outdated
Comment on lines
23
to
25
| android.defaults.buildfeatures.buildconfig=true | ||
| android.nonTransitiveRClass=false | ||
| android.nonFinalResIds=false |
There was a problem hiding this comment.
What's the reason for these? In a single module project non-transitive r shouldn't be relevant
gradle/publishing.gradle
Outdated
| @@ -26,7 +26,7 @@ afterEvaluate { | |||
| publishing { | |||
| publications { | |||
| maven(MavenPublication) { | |||
| from components.release | |||
| from components.findByName('release') ?: components.findByName('debug') | |||
There was a problem hiding this comment.
we should not be falling back to publishing debug code to maven
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.