Allow subscribing to a single resource #1037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new endpoint on `XdsClient` allows one to watch a single URI using the glob collection interface. The watcher will be notified whenever the URI changes or is deleted, which allows for lightweight watches of a singular URI instead of needing to watch the entire cluster.
bohhyang
reviewed
Jan 10, 2025
| } | ||
| else | ||
| { | ||
| metricsProvider.trackLatency(System.currentTimeMillis() - d2Uri.getModifiedTime().getSeconds() * 1000); |
There was a problem hiding this comment.
also need to update _d2Uri and notify the watchers.
bohhyang
reviewed
Jan 10, 2025
| @@ -95,6 +95,23 @@ final void onChanged(ResourceUpdate update) | |||
| } | |||
| } | |||
|
|
|||
| public static abstract class D2UriResourceWatcher | |||
There was a problem hiding this comment.
we should make this extends ResourceWatcher for better code structure, so that:
- watchD2Uri is not needed, and can just reuse watchXdsResource(globCollectionUrn(cluster, uri), watcher).
- D2UriSubscriber is not needed, and can just use ResourceSubscriber.
|
just a reminder for updating the version and changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new endpoint on
XdsClientallows one to watch a single URI using the glob collection interface. The watcher will be notified whenever the URI changes or is deleted, which allows for lightweight watches of a singular URI instead of needing to watch the entire cluster.