Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable modifiable collection transformer for Maps #554

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

li-ukumar
Copy link
Member

@li-ukumar li-ukumar commented Mar 13, 2024

What

Removing modifiable collections for Map type in avro codegen

Why

Maps, unlike Lists, have a key of charseq type which always need to be converted to Utf8 for avro1.4 support. But we cannot apply the same operation to the value. Hence removing this from codegen.

Test

Updated unit test

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (2fd93ac) to head (5d1ffec).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #554      +/-   ##
============================================
- Coverage     46.24%   46.22%   -0.02%     
+ Complexity     4619     4595      -24     
============================================
  Files           412      410       -2     
  Lines         28679    28594      -85     
  Branches       4686     4677       -9     
============================================
- Hits          13262    13218      -44     
+ Misses        13834    13800      -34     
+ Partials       1583     1576       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-ukumar li-ukumar marked this pull request as ready for review March 13, 2024 17:32
@li-ukumar li-ukumar merged commit 46c92a9 into master Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants