Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColdPrimitive*List classes use correct schema. #549

Merged

Conversation

krisso-rtb
Copy link
Contributor

@krisso-rtb krisso-rtb commented Feb 15, 2024

Just a minor fix.

The main change is in 4 classes:

  • ColdPrimitiveBooleanList
  • ColdPrimitiveDoubleList
  • ColdPrimitiveIntList
  • ColdPrimitiveLongList

Copy link
Collaborator

@FelixGV FelixGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a silly mistake! Thanks for catching and fixing it!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51ff79b) 46.20% compared to head (2769d05) 46.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #549   +/-   ##
=========================================
  Coverage     46.20%   46.20%           
- Complexity     4550     4552    +2     
=========================================
  Files           407      407           
  Lines         28443    28443           
  Branches       4642     4642           
=========================================
+ Hits          13141    13143    +2     
  Misses        13731    13731           
+ Partials       1571     1569    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FelixGV FelixGV merged commit 9f838a0 into linkedin:master Feb 15, 2024
2 checks passed
@krisso-rtb krisso-rtb deleted the Cold-Primitive-Lists-with-correct-schema branch February 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants