[parser] throw exception on bad default value in union (#347)

* [parser] throw exception on bad default * exception -> context.addIssue Co-authored-by: David Grossman <dgrosman@linkedin.com>
linkedin · Jun 16, 2022 · 4154243 · 4154243
1 parent ba4ec6b
commit 4154243
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/parser/src/main/java/com/linkedin/avroutil1/parser/avsc/AvscParser.java b/parser/src/main/java/com/linkedin/avroutil1/parser/avsc/AvscParser.java
@@ -386,10 +386,12 @@ private AvroNamedSchema parseNamedSchema(
                                 //(legal) default values are expected to match the 1st union branch
                                 defaultValueExpectedSchema = ((AvroUnionSchema) defaultValueExpectedSchema).getTypes().get(0).getSchema();
                             }
-                            LiteralOrIssue defaultValurOrIssue = parseLiteral(fieldDefaultValueNode, defaultValueExpectedSchema, fieldName.getValue(), context);
-                            if (defaultValurOrIssue.getIssue() == null) {
+                            LiteralOrIssue defaultValueOrIssue = parseLiteral(fieldDefaultValueNode, defaultValueExpectedSchema, fieldName.getValue(), context);
+                            if (defaultValueOrIssue.getIssue() == null) {
                                 //TODO - allow parsing default values that are branch != 0 (and add an issue)
-                                defaultValue = defaultValurOrIssue.getLiteral();
+                                defaultValue = defaultValueOrIssue.getLiteral();
+                            } else {
+                                context.addIssue(defaultValueOrIssue.getIssue());
                             }
                             //TODO - handle issues
                         } else {