Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-unlocalized-strings): ignore Literals in computed MemberExpression #56

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Oct 11, 2024

Completely ignore from checking literals in computed member expressions, eq:

Partially fixes: #38
Tracking issue #50

// valid
obj["key with space"] 
obj[`key with space`]

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (3c6d349) to head (3c79d59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   94.92%   94.96%   +0.04%     
==========================================
  Files          10       10              
  Lines         473      477       +4     
  Branches      156      156              
==========================================
+ Hits          449      453       +4     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit edb2bc1 into main Oct 11, 2024
6 checks passed
@andrii-bodnar andrii-bodnar deleted the no-unlocalized-strings-computed-ignore branch October 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-unlocalized-strings should ignore string keys for dereferencing object values
2 participants