Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-unlocalized-strings): ignoreProperty support MemberExpression assignments #51

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Oct 10, 2024

Fixing #37

i've found this one is more annoying that the rest, because

MyComponent.displayName = "MyComponent"

Is quite popular pattern in react ecosystem.

Related #50

What was changed:

  • ignoreProperty now applies to the MyComponent.displayName = "MyComponent"
  • displayName is ignored by default

@andrii-bodnar andrii-bodnar linked an issue Oct 11, 2024 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit 1ecc912 into lingui:main Oct 11, 2024
4 checks passed
@timofei-iatsenko timofei-iatsenko deleted the fix-no-unlocalized-string-rule branch October 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoreProperty does not work as expected
2 participants