fix(no-unlocalized-strings): utilize ignoreFunction which is used as …

…CallExpression (#21)
lingui · Dec 8, 2023 · e84de6e · e84de6e
1 parent 5078ea0
commit e84de6e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/rules/no-unlocalized-strings.ts b/src/rules/no-unlocalized-strings.ts
@@ -94,7 +94,9 @@ const rule: RuleModule<string, Option[]> = {
       return whitelists.some((item) => item.test(str))
     }
 
-    function isValidFunctionCall({ callee }: TSESTree.CallExpression | TSESTree.NewExpression) {
+    function isValidFunctionCall({
+      callee,
+    }: TSESTree.CallExpression | TSESTree.NewExpression): boolean {
       switch (callee.type) {
         case TSESTree.AST_NODE_TYPES.MemberExpression: {
           if (
@@ -116,6 +118,13 @@ const rule: RuleModule<string, Option[]> = {
           }
           return calleeWhitelists.simple.indexOf(callee.name) !== -1
         }
+        case TSESTree.AST_NODE_TYPES.CallExpression: {
+          return (
+            (callee.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression ||
+              callee.callee.type === TSESTree.AST_NODE_TYPES.Identifier) &&
+            isValidFunctionCall(callee)
+          )
+        }
         default:
           return false
       }

diff --git a/tests/src/rules/no-unlocalized-strings.test.ts b/tests/src/rules/no-unlocalized-strings.test.ts
@@ -22,6 +22,11 @@ ruleTester.run<string, Option[]>('no-unlocalized-strings', rule, {
     {
       code: 'i18n._(t`Hello ${nice}`)',
     },
+    { code: 't(i18n)({ message: `Hello ${name}` })' },
+    {
+      code: 'custom.wrapper()({message: "Hello!"})',
+      options: [{ ignoreFunction: ['custom.wrapper'] }],
+    },
     { code: 'name === `Hello brat` || name === `Nice have`' },
     { code: 'switch(a){ case `a`: break; default: break;}' },
     { code: 'a.indexOf(`ios`)' },