feat: extend function call support for no-expression-in-message to se…

…lect and selectOrdinal
lingui · Oct 11, 2024 · 7dbbdc4 · 7dbbdc4
1 parent 7a8d062
commit 7dbbdc4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/rules/no-expression-in-message.ts b/src/rules/no-expression-in-message.ts
@@ -26,16 +26,18 @@ export const rule = createRule({
   defaultOptions: [],
 
   create: function (context) {
+    const linguiMacroFunctionNames = ['plural', 'select', 'selectOrdinal']
+
     return {
       'TemplateLiteral:exit'(node: TSESTree.TemplateLiteral) {
         const noneIdentifierExpressions = node.expressions
           ? node.expressions.filter((expression) => {
               const isIdentifier = expression.type === TSESTree.AST_NODE_TYPES.Identifier
-              const isCallToPluralFunction =
+              const isCallToLinguiMacro =
                 expression.type === TSESTree.AST_NODE_TYPES.CallExpression &&
                 expression.callee.type === TSESTree.AST_NODE_TYPES.Identifier &&
-                expression.callee.name === 'plural'
-              return !isIdentifier && !isCallToPluralFunction
+                linguiMacroFunctionNames.includes(expression.callee.name)
+              return !isIdentifier && !isCallToLinguiMacro
             })
           : []
 

diff --git a/tests/src/rules/no-expression-in-message.test.ts b/tests/src/rules/no-expression-in-message.test.ts
@@ -31,6 +31,12 @@ ruleTester.run(name, rule, {
     {
       code: 't`Hello ${plural()}`',
     },
+    {
+      code: 't`Hello ${select()}`',
+    },
+    {
+      code: 't`Hello ${selectOrdinal()}`',
+    },
   ],
   invalid: [
     {