feat: allow calls to plural function in no-expression-in-message (#48)

lingui · Oct 11, 2024 · 7a8d062 · 7a8d062
1 parent f99a709
commit 7a8d062
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/rules/no-expression-in-message.ts b/src/rules/no-expression-in-message.ts
@@ -29,8 +29,13 @@ export const rule = createRule({
     return {
       'TemplateLiteral:exit'(node: TSESTree.TemplateLiteral) {
         const noneIdentifierExpressions = node.expressions
-          ? node.expressions.filter((expression: { type: string }) => {
-              return expression.type !== TSESTree.AST_NODE_TYPES.Identifier
+          ? node.expressions.filter((expression) => {
+              const isIdentifier = expression.type === TSESTree.AST_NODE_TYPES.Identifier
+              const isCallToPluralFunction =
+                expression.type === TSESTree.AST_NODE_TYPES.CallExpression &&
+                expression.callee.type === TSESTree.AST_NODE_TYPES.Identifier &&
+                expression.callee.name === 'plural'
+              return !isIdentifier && !isCallToPluralFunction
             })
           : []
 

diff --git a/tests/src/rules/no-expression-in-message.test.ts b/tests/src/rules/no-expression-in-message.test.ts
@@ -28,6 +28,9 @@ ruleTester.run(name, rule, {
     {
       code: 't`Hello ${hello}`',
     },
+    {
+      code: 't`Hello ${plural()}`',
+    },
   ],
   invalid: [
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,6 +28,9 @@ ruleTester.run(name, rule, { @@
         {
           code: 't`Hello ${hello}`',
         },
+        {
+          code: 't`Hello ${plural()}`',
+        },
       ],
       invalid: [
         {
@@ Expand Down @@