fix: ban top level t() calls aside from t`` calls

lingui · Dec 14, 2023 · 3fc28bc · 3fc28bc
1 parent 7c588c4
commit 3fc28bc
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/rules/t-call-in-function.ts b/src/rules/t-call-in-function.ts
@@ -13,7 +13,7 @@ const rule: RuleModule<string, readonly unknown[]> = {
       recommended: 'error' as RuleRecommendation,
     },
     messages: {
-      default: 't`` call should be inside function',
+      default: 't`` and t() call should be inside function',
     },
     schema: [
       {
@@ -56,7 +56,19 @@ const rule: RuleModule<string, readonly unknown[]> = {
       ['ClassDeclaration TaggedTemplateExpression'](node: TSESTree.TaggedTemplateExpression) {
         handler(node)
       },
-
+      ['CallExpression:exit'](node: TSESTree.CallExpression) {
+        const scope = context.getScope()
+        if (
+          scope.type === 'module' &&
+          node.callee.type === TSESTree.AST_NODE_TYPES.Identifier &&
+          node.callee.name === 't'
+        ) {
+          context.report({
+            node,
+            messageId: 'default',
+          })
+        }
+      },
       ['TaggedTemplateExpression:exit'](node: TSESTree.TaggedTemplateExpression) {
         if (visited.has(node)) return
         if (!isTTaggedTemplateExpression(node)) {

diff --git a/tests/src/rules/t-call-in-function.test.ts b/tests/src/rules/t-call-in-function.test.ts
@@ -34,7 +34,13 @@ ruleTester.run<string, readonly unknown[]>('t-call-in-function', rule, {
                 padding: ${tokens.spacing20};\
               `',
     },
+    {
+      code: 'const a = () => {t("Hello")}',
+    },
   ],
 
-  invalid: [{ code: 't`Hello`', errors }],
+  invalid: [
+    { code: 't`Hello`', errors },
+    { code: 't("Hello")', errors },
+  ],
 })