fix(no-unlocalized-strings): ignore Literals in computed MemberExpres…

…sion
lingui · Oct 11, 2024 · 3c79d59 · 3c79d59
1 parent 3c6d349
commit 3c79d59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/rules/no-unlocalized-strings.ts b/src/rules/no-unlocalized-strings.ts
@@ -368,6 +368,10 @@ export const rule = createRule<Option[], string>({
       'Property > Literal'(node: TSESTree.Literal) {
         onProperty(node)
       },
+      'MemberExpression[computed=true] > Literal'(node: TSESTree.Literal) {
+        // obj["key with space"]
+        visited.add(node)
+      },
       "AssignmentExpression[left.type='MemberExpression'] > Literal"(node: TSESTree.Literal) {
         const assignmentExp = node.parent as TSESTree.AssignmentExpression
         const memberExp = assignmentExp.left as TSESTree.MemberExpression
@@ -453,6 +457,10 @@ export const rule = createRule<Option[], string>({
           visited.add(node)
         }
       },
+      'MemberExpression[computed=true] > TemplateLiteral'(node: TSESTree.TemplateLiteral) {
+        // obj[`key with space`]
+        visited.add(node)
+      },
       'Property > TemplateLiteral'(node: TSESTree.TemplateLiteral) {
         onProperty(node)
       },

diff --git a/tests/src/rules/no-unlocalized-strings.test.ts b/tests/src/rules/no-unlocalized-strings.test.ts
@@ -180,6 +180,8 @@ ruleTester.run<string, Option[]>(name, rule, {
       code: `const test = { text: 'This is not localized' }`,
       options: [{ ignoreProperty: ['text'] }],
     },
+    { code: `obj["key with space"] = 5` },
+    { code: `obj[\`key with space\`] = 5` },
   ],
 
   invalid: [