Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand to 0.9 #414

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

An alternative to adding the .cargo/config.toml would be to add it to the env in CI.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously I'm not a massive fan of being forced to add .cargo, I agree that there probably isn't a better alternative. What a mess

@waywardmonkeys
Copy link
Contributor Author

It is only needed if we do and run a wasm build for testing perhaps. It is really an integration issue at the final binary level, right? But that is a larger change.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Feb 6, 2025
Merged via the queue into linebender:main with commit 4dfe1f3 Feb 6, 2025
15 checks passed
@waywardmonkeys waywardmonkeys deleted the update-rand branch February 6, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants