Add Repository settings UI #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
approved these changes
Dec 30, 2024
ikhoon
approved these changes
Jan 6, 2025
| return credentials(loginUser, future); | ||
| } | ||
|
|
||
| private static CompletableFuture<List<Credential>> credentials(User loginUser, |
There was a problem hiding this comment.
The method name seems vague. How about maybeMaskSecret()?
There was a problem hiding this comment.
That's a good name. 👍
| * Returns a mirroring credential of the specified {@code id}. | ||
| * Returns a list of credentials of the specified repository. | ||
| */ | ||
| CompletableFuture<List<Credential>> credentials(String repoName); |
There was a problem hiding this comment.
I think it would be good to clarify the function names to improve readability and prevent mistakes. The suggested method names are longer though.
repoCredentials()projectCredentials()
| @@ -58,7 +58,7 @@ | |||
|
|
|||
| public final class DefaultMetaRepository extends RepositoryWrapper implements MetaRepository { | |||
|
|
|||
| public static final String PATH_CREDENTIALS = "/credentials/"; | |||
| private static final String PATH_CREDENTIALS = "/credentials/"; | |||
|
|
|||
| public static final String PATH_MIRRORS = "/mirrors/"; | |||
There was a problem hiding this comment.
Make this field as private as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To provide users with a dedicated interface for managing repository settings.
Modifications:
RepositorySettingsPagecomponent for centralized repository settings management.ProjectRoledefinitions into a single locationAppMemberListandAppTokenListinto a unifiedAppEntityListcomponent to reduce code duplicationDeleteMemberandDeleteTokenfunctionalities into a singleDeleteAppEntitycomponent to reduce code duplicationResult: